Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Skip system/settings.php #117

Merged
merged 1 commit into from
Jan 20, 2024
Merged

[BUGFIX] Skip system/settings.php #117

merged 1 commit into from
Jan 20, 2024

Conversation

mbrodala
Copy link
Contributor

The config/system/settings.php is commonly updated through the TYPO3 backend and exported accordingly. Thus coding style standards can and should not be applied here.

The config/system/settings.php is commonly updated through the TYPO3 backend and exported accordingly. Thus coding style standards can and should not be applied here.
@bmack
Copy link
Member

bmack commented Dec 12, 2023

What kind of change happened in your use-case that you did not want to happen?

For projects, the config should be set to "src/" (or wherever your PHP files are located), and for extensions the config/system/settings file is usually not available.

@mbrodala
Copy link
Contributor Author

The change we saw was minimal, an additional newline between <?php and return .... Still, this would be dropped the next time the settings.php is updated via TYPO3 BE, requiring another CS fix.

We do not use src/ in TYPO3 distributions yet but packages/. Aside from that we use __DIR__ to process the whole project so maybe that's the root cause. Sure, with the default __DIR__ . 'src/ one would not get suggestions to fix something in config/.

@bmack
Copy link
Member

bmack commented Dec 12, 2023

src/ or packages/ would be highly recommended, otherwise php-cs-fixer might go over your vendor folder :)

@mbrodala
Copy link
Contributor Author

We usually use a list of directories which should not be processed instead. This way we can be sure that newly added files are covered automatically.

In fact, this very package does that:

$finder->exclude(['vendor', 'typo3temp', 'var', '.build']);

So we're fine. :-)

@bmack bmack changed the title Skip system/settings.php [BUGFIX] Skip system/settings.php Jan 20, 2024
@github-actions github-actions bot added the bug Something isn't working label Jan 20, 2024
@bmack bmack merged commit 4660e61 into TYPO3:main Jan 20, 2024
4 of 5 checks passed
@mbrodala mbrodala deleted the patch-1 branch January 22, 2024 08:10
ochorocho pushed a commit to ochorocho/coding-standards that referenced this pull request Jan 28, 2024
[BUGFIX] Skip system/settings.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants